Typo commented on a Page, IRCManager1.33  -  Sep 21, 2008

I loaded your script and before I even tried using it I noticed the dialog. It honestly leaves a lot to be desired.

I really dont understand why you make the text boxes in the dialog table and then fill them with the text in dialog events instead of in the table.

Since you do it like that you end up with a lot of empty space until you initiate one of the events that fill it.

You should consider using $inputs for warnings such as the "Please select a server" warning that appears when they try and instead of reserving space in the dialog for an empty text box that isnt needed unless an error is made.

I also don't understand why you make those silly looking up and down buttons for your list instead of using the verticle scrollbar option in the list.

I think the dialog could be a lot smaller and better organized and I will even offer my help to edit it if you need assistance.

I decided to do some major editing to yours to show you what I mean. This is your dialog edited but the events in the script would need some editing to match the new dialog.
Your dialog:
Image
My version:
Image
And incase you want it, the code:

dialog -l ircmanager {
  title "Loading..."
  size -1 -1 304 393
  option pixels
  text "IRC Manager", 1, 112 5 79 14, center
  list 2, 7 39 206 91, size vsbar
  button "Add Server", 3, 214 41 80 20
  button "Reset", 4, 214 75 80 20
  button "Cancel", 5, 214 108 80 20
  text "Server settings:  Use a '+' infront of SSL ports!  Use a ',' between the channels!", 10, 12 140 279 28, center
  text "Server:", 11, 26 172 39 14
  text "Port:", 12, 26 193 27 14
  text "Channels:", 13, 26 215 51 14
  text "Personal settings:  Don not enter a password if you are on a public PC!", 14, 13 243 277 27, center
  text "Nickname:", 15, 24 276 54 14
  text "Password:", 16, 24 296 52 14
  edit "", 30, 76 170 200 20
  edit "", 31, 76 191 200 20
  edit "", 32, 76 212 200 20
  edit "", 33, 77 272 200 20
  edit "", 34, 78 293 200 20, pass
  check "Enable IRCManager", 40, 10 325 200 20
  check "Start IRCManager on connect", 41, 10 341 200 20
  button "Ok", 100, 113 367 80 20, ok
  box "", 6, 4 13 295 120
  box "", 7, 4 131 295 105
  text "Servers", 8, 112 25 79 14, center
  box "", 9, 4 235 295 84
  box "", 17, 4 317 295 46
  box "", 18, 0 -3 304 396
}

Notice how I actually set the text in the dialog table instead of in an event.
Btw, the picture I took of the dialog was actually without any dialog events allowed to initiate. I disabled all of them because they interfered with the new dialog and wouldn't allow it to load properly.

I noticed you have a timer unsetting that needs to be silenced. To silence it, put a . in front of the timer command, i.e. .timer 0 1 echo -a hi. Which will stop " 0 timer(s) matching ircm halted" from showing up in the status window.

I also noticed than you dont have an event on unload that unsets the left over variables so you may want to add that as well.

Sorry if it seems like im nailing you with a thousand things.

 Respond  
Are you sure you want to unfollow this person?
Are you sure you want to delete this?
Click "Unsubscribe" to stop receiving notices pertaining to this post.
Click "Subscribe" to resume notices pertaining to this post.