Pros:
Cons:
Quite a bit. No need of halts, for the == $null simple use a !$read(etc), (as said before) just use $lines(quotes.txt) because it\'s useless to have a variable, remove /\'s, provide things such as if ($2) to error check, also: for things such as != $null you don\'t need those just use the actual identifier or if statement.
Also, you should, as a script writer, accept comments of others and fix mistakes. If you \'don\'t feel like editing\' the snippet, don\'t expect a high score. :)
I would take a look @ the other ones on here and learn a little from them. For example, napa182\'s quote system. That\'s efficient and it has a lot of variety. I\'m not saying deliberately take things out of snippets but just take a look on how others approached it. Maybe you\'ll find many more ideas.