Quote:
Is it ever so necessary for every comment to be a criticism of the trigger
Actually if you see it as an "open discussion," rather than a "criticism," it can benefit every one of us to learn from each other and gain more knowledge.
Agreed.
-Cool gooshie I shall steer towards your method next time :)
-fordlawnmower, good idea about using a variable to store the sockname throughout the opening hash table. :D As for using sockmark instead, I simply havn't tried it yet- I think I will give it a go next time though :)
Thanks for the feedback guys
Code:
if (!$2) || (!$3) || ($2 !ison $chan) { .notice $nick $logo(Error) Please specify a song/nick $chr(124) !dedication | halt }
you could remove the !$2 part of the /if statement seeing as if $2 isnt on $chan it wouldnt matter if there was a $2?
I can see what you mean however, in the unlikely event that someone in the channel shares the same name as the dedication i think it should stay in :pCode:
if ($left($1,1) == !) .notice $nick $logo(Dedication) $c2(Dedication sent to $2 $+ !)
may be deliberate but i dont see anything for if $left($1,1) == @
This was deliberate to prevent ".notice $nick $logo(Dedication) $c2(Dedication sent to $2 $+ !)" occurring if the command is used publicly, theres no point displaying the message if they can see the result in the channel.Code:
hadd -m $sockname end $regml(1)
seems redundant if ur just gonna free the table in a few lines comepared to just using $regml(1) instead of $hget($sockname,end)
This however, is very true thanks for pointing it out.
I wasn't expecting to come under as much scrutiny as this :o
& thanks gooshie about the hash tables, i wasn't aware that -m can be used once, when the table is created. Also, this snippet was originally made for my bot which has flood protection - the snippet performs the task outlined and simple flood protection can be added easily.
To me: > on $:text:/^!@/Si:#: {
if ($regml(1) == dedi) || ($regml(1) == dedicate) { ...
}
Or
Code:
on $:text:/^!@/Si:#: {
if ($istok(dedi dedicate,$regml(1),32)) {
does not seem simplified, if anything you are complicating things. I was indeed aiming for it to just match "dedi" or "dedicate".
Is it ever so necessary for every comment to be a criticism of the trigger?
As much as I appreciate it as I do have alot still to learn about regex maybe give me a little feedback on the rest of it too? :D
I always admired this script of yours Zep, a socket would have been easier and simpler but if it does the job it does the job and this is/was unique when you made it. Never got on here to comment tho.
I will say though you could shorten it a little by setting your vars like this:
var %a blah,%b blah, %c etc
that would reduce alot of the pipes and make it look a little neater. Plus, why did you not script it around that exp alias you made? :p
Goodjob though zep