if ($2 isin AquariusPiscesAriesTaurusGeminiCancerLeoVirgoLibraScorpioSagittariusCapricorn) {
You could
if ($istok(Aquarius.Pisces.Aries.Taurus.Gemini.Cancer.Leo.Virgo.Libra.Scorpio.Sagittarius.Capricorn,$2,46))
That would prevent someone trying !horoscpe Tau or !horoscope a
Also, make sure the socket isnt open with if ($sock(horo))
It will give you annoying errors if you try reopening a socket thats already opened
Bear
Please test snippets before posting them
Aliases do not have a $nick identifier
You could have used /play too
on :text:.view :*: play $2 $nick
I believe that does it too
This snippet is very dangerous though
If you have auto-identify preform commands, people could just view your mirc.ini file and get your password
Bear
Please test your snippets before submitting them, there is obviously a bracket align issue with this one
There is also:
on :TEXT::? { Which Im fairly sure you need the : after the ?
Also, ini files are slow, hash tables might have been better for this
A few pointers
if (%a == $null) is the same as if (!%a)
With one lines commands after ifs, you dont need { }
You should also set up a menu or dialog to let them add channels so tey dont have to change #CHANNEL in 50 places
Inside script events you can also use $chan
Its a good script but it looks like it could use abit most testing...
Bear
Maybe the scorer just thought it deserved a 3?
You can look through all the snippets
You\'ll see how much time people have spent on snippets with 7\'s and 9\'s
It annoys me when scripts get 6s for something that would take all of 3 minutes to code, and its poorly written. This script is ok, but it has been done before. Its also a bit long for the job.
You could look at the $nick identifier. I think that could help improve this abit.
Bear
Its not a bad script, I can see how it could be useful
It would be nice to be able to run multiple polls on a few channels
Also, variables are slow and... consuming for someone that might have a few hundred votes
I\'d recommend ini files or hash tables
That would make multiple polls more plausible
Bear
I made something to this extent... It used .ini files, was shorter in code, but possibly slower
I recoded it with alot of stats, custom window viewing, a dialog, and hash tables but never uploaded the new one
Maybe I will some day :P
I would definiatly say text files arent the way to go, too messy
Bear
I go through and I see these script that have been done 100 times before, take up 10x the space of something I would make and never post.
I give them 1s or 2s and move on
Its great people are learning to script, but code that sucks and is useless doesnt deserve to get a 4 or a 5. I spend a very long time on snippets I upload. I make them for myself, then figure hell, why not post it. If it sucks, give it a 2.
I have posted bad scripts before, an looking back on it I know they should have gotten lower scores
You are one of the best scripters on here, Id hate to see you go.
This script is Very useful and deserves a 9.
Bear
This completely randomizes your text colors I made this awhile ago, but I finally decided to submit it To use this script, instead of saying "Random colors", you say "c Random Colors", and it will send the channels/person the words "Random colors", just in completely random mIRC colors Warnng: This script will not randomize colors for numbers