Kirby, it is not a case of not understanding the script or needing you to elaborate on any parts. I'm merely stating a point that obviously others have an issue with too. Was I flaming? No, what are comments for? For leaving constructive feedback, likes/dislikes, additions etc of the script? Yes.
I was looking for a good imdb script to use as I didn't much feel like coding one myself, laziness, lack of time, whatever the reason.
As I said, the script is great & works very well. I understand how it works but don't like the colours, the way it delivers to the channel etc. Rarely when I use someone else's script do I not edit it to suit the way I like things & I'm sure I am not the only one. I was simply stating for that reason alone I would not use it. Call it constructive criticism or flaming as you wish, but if you are supplying scripts in the hope that other people will use them, maybe you would like to know what others think for future reference in the hope that more people will use it.
In future I will simply not comment on any of your snippets in an effort to avoid offending your fragile ego further.
Script is great and works very well, but I'm with FordLawnmower on the code layout. There is never any need for such long lines of code, that's what the Enter key is for.
I would start on the next line instead of using " | " but I guess it's down to personal preference. I think it makes it a lot easier on the eye if you wish to edit or look at the script & removes the need to scroll in the editor.
For this reason I would not use this script, I could edit it to make it how I like it, or I could just use another or write one.
This small simple script was inspired by the Transformer Name Generator that was on The Cartoon Network website for a while. It has since been removed from the site so I thought I'd make this script. It generates the exact same results as the Cartoon Networks did because it works on the same basis as explained here: http://tfwiki.net/wiki/Transformers_Name_Generator
Vexx,
if ($2 = $nick) is if the person using the !seen command types in their own name.
if ($2 = $me) is if the person tries to perform the !seen command on the bot/user running the script. It\'s just a bit of fun. It could be left so it just says they are on the channel, but it just adds a bit extra to the script to give a humerous answer if a user \"!seen\'s\" themselves or the bot/user running the script. :)
Thought this might be useful, I have progressed a lot since my last comment, which I am unable to delete. I think I had other errors which accounted for the error I had before. Anyway I edited part of the script & added bits to handle the 319 code from the raw whois. Now instead of just saying if the user is on the server, it now returns a list of channels the user you \"!seen\" is on. It now also handles if users are on the server but not in any rooms and tells you this info also.
The bits I added may be a little crude, but it works. Changed the
msg $chan\"
to
.notice %xseen.nick
in a lot of places for my own use so as not to spam the room with people going mad with the script. It puts a nice touch to an already great script I think. :-)
Here is the bit i edited:
raw 402:*: {
if (%xseen) {
if (!$hget(xSeen,%xseen.target)) { .notice %xseen.nick 12Sorry,4 %xseen.target 12was not found in my database, or on the server. }
if ($hget(xSeen,%xseen.target)) {
var %xseen.data $left($hget(xSeen,$2),1)
tokenize 32 $hget(xSeen,%xseen.target)
if ($1 = Q) { .notice %xseen.nick 4 $+ %xseen.target 12was last seen Quitting 4(Quit Message: $4- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = S) { .notice %xseen.nick 4 $+ %xseen.target 12was last seen by me on the server4 $duration($calc($ctime - $3)) ago. }
if ($1 = K) { .notice %xseen.nick 4 $+ %xseen.target 12was last seen being kicked from4 $4 (Kick Reason: $5- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = P) { .notice %xseen.nick 4 $+ %xseen.target 12was last seen parting4 $4 (Part Reason: $5- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = N) { .notice %xseen.nick 4 $+ %xseen.target 12was last seen changing his/her nick to4 $4 $duration($calc($ctime - $3)) ago. }
}
xdefclear
}
if (%idle.time.get = on) {
.notice %idle.x 12Sorry4 %idle.x $+ 12,4 %idle.nick 12was not found on this server. Try 4!seen12 %idle.nick
unset %idle.nick
unset %idle.chan
unset %idle.time.get
unset %idle.x
halt
}
}
raw 319:*:{
if (%xseen) {
.notice %xseen.nick 12User4 $2 12is currently in:9 $3-
.notice %xseen.nick 12Click a room(s) to join them, or type 4!search 12& I\'ll tell them you\'re looking for them.
set -u60 %xfind. [ $+ [ %xseen.nick ] ] %xseen.target
hadd -m xSeen %xseen.target S $nick $ctime
xdefclear
;halt
}
}
raw 317:*:{
if (%xseen) {
.notice %xseen.nick 4 $+ $2 12was found on the server but not in any channel.
.notice %xseen.nick 12If you would like me to inform4 $2 12you are looking for them, type 4!search
set -u60 %xfind. [ $+ [ %xseen.nick ] ] %xseen.target
hadd -m xSeen %xseen.target S $nick $ctime
xdefclear
}
if (%idle.time.get = on) {
set %temp.idle.time $3
.notice %idle.x 4 $+ $2 12has been idle for4 $duration(%temp.idle.time)
unset %temp.idle.time
unset %idle.nick
unset %idle.chan
unset %idle.time.get
halt
}
}
Hi there, I\'m new to the site & new to IRC scripting. This is the first time I have studied it & the first time editing it, (learning as I go) so go easy on me if there are glaringly obvious errors.
I really liked this script as it was the only one I could find that used WHOIS to find a user that was not in the channel. I added it to a mIRC bot, (Yourbot IRC Bot 4.5.2) which was intergrated into mIRC v6.2, but the last user action (ie: Kick, Quit, Part etc) database wouldnt function properly & the script would freeze giving the bot client the error message: * Invalid format: $left (line 17, seen.mrc).
After some playing with the code & changing the v6.2 mIRC exe for the new v6.31 exe, the script works exactly as it should for my bot.
Like I said, it worked for me, there may have been a much easier way to sort the problem, but I didn\'t know it. :-) Thought I would share this in case other people had the same problem, or to see if there was an easier way of fixing the problem.
The code I changed was:
raw 402:*: {
if (%xseen) {
if (!$hget(xSeen,%xseen.target)) { msg %xseen.chan 12Sorry,4 %xseen.target 12was not found in my database, or on the server. }
if ($hget(xSeen,%xseen.target)) {
var %xseen.data $left($hget(xSeen,%xseen.target),1)
tokenize 32 $hget(xSeen,%xseen.target)
if ($1 = Q) { msg %xseen.chan %xseen.target was last seen Quitting (Quit Message: $4- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = S) { msg %xseen.chan %xseen.target was last seen by me on the server $duration($calc($ctime - $3)) ago. }
if ($1 = K) { msg %xseen.chan %xseen.target was last seen being kicked from $4 (Kick Reason: $5- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = P) { msg %xseen.chan %xseen.target was last seen parting $4 (Part Reason: $5- $+ ) $duration($calc($ctime - $3)) ago. }
if ($1 = N) { msg %xseen.chan %xseen.target was last seen changing his/her nick to $4 $duration($calc($ctime - $3)) ago. }
}
xdefclear
}